Skip to content

Route access logs to stdout#1315

Merged
lovasoa merged 2 commits into
mainfrom
route-access-logs-stdout
Jun 12, 2026
Merged

Route access logs to stdout#1315
lovasoa merged 2 commits into
mainfrom
route-access-logs-stdout

Conversation

@lovasoa

@lovasoa lovasoa commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • mark SQLPage request-completion logs with a dedicated sqlpage::access target
  • route only that access-log target to stdout in the logfmt layer
  • keep diagnostics, warnings, internal errors, and test logging on stderr
  • document the stdout move and the required updates for target-scoped log filters and stderr-only log pipelines

Admin impact

Broad filters such as sqlpage=info keep access logs. Deployments using target-specific filters like sqlpage::webserver::http=info should add sqlpage::access=info. Log pipelines that only ingest stderr should also ingest stdout for request-completion access logs.

Validation

  • cargo fmt --all
  • cargo test
  • cargo clippy --all-targets --all-features -- -D warnings

@lovasoa lovasoa marked this pull request as ready for review June 10, 2026 20:27
@lovasoa lovasoa force-pushed the route-access-logs-stdout branch from eddef6d to c0e855b Compare June 10, 2026 20:32

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c0e855b832

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/webserver/http.rs
@lovasoa lovasoa force-pushed the route-access-logs-stdout branch from c0e855b to 18fae5b Compare June 10, 2026 20:39
@lovasoa lovasoa linked an issue Jun 10, 2026 that may be closed by this pull request
@lovasoa lovasoa merged commit 9ca655f into main Jun 12, 2026
51 checks passed
@lovasoa lovasoa deleted the route-access-logs-stdout branch June 12, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Log output redirected to stderr

1 participant